Poker Hand XML - Page 7

Shoe Lace · #61 08-01-2007, 09:47 AM

[ QUOTE ]
but I still think its missing some data and it isn't formatted right (element names cant be assigned values, i.e. <position="1" ...>

[/ QUOTE ]

Missing stats is no problem. That's the beauty of doing it like this. Adding an ante or straddle is trivial. Add them as attributes to the 'hand' node.

As for the other problem, that was my fault. [img]/images/graemlins/laugh.gif[/img]

The lines should look like:
<player position="1" action="Fold" value="0">

[ QUOTE ]
It is my opinion that each card is a seperate piece of data and should be parsed inidividually instead of making the reader do the extra work (which the read will have to do every time). So essentially this is just a space/human readability issue, right?

[/ QUOTE ]

I think as a developer I'd prefer them to share the same attribute separated by just a space.

This allows you to split the attribute and get back an array of cards regardless of how many exist.

You could also use the same exact routine to parse the community cards (again, the amount of cards do not matter).

This seems ideal for a project that's required to be as generic and future proof as possible.

Having them separated wouldn't cause worse performance really. Remember, just because a language has built in classes or has a way of supporting XML doesn't mean the code gets executed "invisibly". The CPU is still doing work.

Tickner · #62 08-01-2007, 09:52 AM

alright, I will rework my example and try to condense it by adding more attributes instead of so many elements.

Shoe Lace · #63 08-01-2007, 11:08 AM

[ QUOTE ]

alright, I will rework my example and try to condense it by adding more attributes instead of so many elements.

[/ QUOTE ]

IMO it needs more than just replacing some elements as attributes. It's the flow/structure of the file that troubles me.

bengele · #64 08-01-2007, 12:24 PM

Tickner,

I kind of like what you have started here. A few things I would change:

1. I mentioned this one before but having constant values in mixed case ("PartyPoker", "TexasHoldem", "NoLimit", etc) always seemed error prone to me.
2. In your card element I think your player and pocket attributes are redundant. Doesn't having a value in player imply that it is a pocket card? I also think that card is an attribute of a player and not the other way around. Maybe you could move the player attribute to the cards element or something like that.
3. I am a little surprised everyone has a summary section. Does every site include this information in there hand histories?
4. What does your mucked cards section look like?

I wish we where taking more of an OO design philosophy to this. When I put together a schema I usually design my data types fist and decide what attributes belong with what data types. Then I take the data types and assemble them into what I want the instance document to look like. I find that I get a lot more reuse out of my data types when I do this and it makes changes easier as well.

MuppetBingo · #65 08-01-2007, 03:44 PM

I've tried to build on some of the earlier suggestions in this thread. I am a Java programmer with about 8 years of experience and I see XML every day, though creating XSDs from scratch is on the fringe of my field.

But here's my submission for an example of a poker hand xml.

(the stuff in 
<game type="texasholdem" format="tournament" bettingtype="nolimit">

<tournament buyin="10" vig="1" id="56210298" currency="USD"/>
<cashgame maxbuyin="400" bigblind="2" currency=""/>
</game>
<players>
<player id="MuppetBingo" stack="1500" seat="1" sittingout="false"/>
<player id="KermitIsGreen" stack="1500" seat="4" sittingout="false"/>
<player id="Animal" stack="1500" seat="5" sittingout="false"/>
</players>
</context>
<rounds>

<antes>
<ante playerId="MuppetBingo" amount="2"/>
<ante playerId="KermitIsGreen" amount="2"/>
<ante playerId="Animal" amount="2"/>
</antes>


<round id="preflop">

<deal>

<cards playerId="MuppetBingo" open="false" value="Ac Ad"/>
</deal>

<actions>


<bet playerId="MuppetBingo" forced="true" type="smallblind" amount="10"/>
<bet playerId="KermitIsGreen" forced="true" type="bigblind" amount="20"/>
<bet playerId="Animal" forced="false" type="straddle" amount="40"/>
<bet playerId="MuppetBingo" amount="10"/>
<bet playerId="KermitIsGreen" amount="30"/>
<call playerId="Animal" amount="30"/>
<call playerId="MuppetBIngo" amount="20"/>
</actions>
</round>
<round id="flop">
<deal>

<cards open="true" value="7c 2s Qh"/>
</deal>
<actions>

<call playerId="MuppetBingo" amount="0"/>
<bet playerId="KermitIsGreen" amount="50"/>
<fold playerId="Animal"/>
<call playerId="MuppetBIngo" amount="50"/>
</actions>
</round>
<round id="turn">
<deal>
<cards open="true" value="9h"/>
</deal>
<actions>
<call playerId="MuppetBingo" amount="0"/>
<call playerId="KermitIsGreen" amount="0"/>
</actions>
</round>
<round id="river">
<deal>
<cards open="true" value="Kc"/>
</deal>
<actions>
<call playerId="MuppetBingo" amount="0"/>
<call playerId="KermitIsGreen" amount="0"/>
</actions>
</round>
</rounds>
<result totalpot="280" rake="1.5">
<hands>

<hand playerId="MuppetBingo" mucked="false" cards="Ac Ad"/>
<hand playerId="KermitIsGreen" mucked="false" cards="As Ks"/>
<hand playerId="Animal" mucked="true"/>
</hands>
<pots>
<pot number="1" value="278.5">
<winners>

<winner playerId="MuppetBingo" amount="278.5" winningHand="Ac Ad Qh Kc 9h"/>
</winners>
</pot>
</pots>
</result>
</pokerhand>
</pre><hr />

1) If we are playing high-low poker we just split each pots into two, one for high and and one for low.

MuppetBingo · #66 08-01-2007, 03:58 PM

We also need to handle player's cutting link midway.

Tickner · #67 08-01-2007, 04:27 PM

Muppet,

Excellent structure. I have to run now late for a meeting but I will be focusing more on PokerHandXML tomorrow morning and we can get this thing close to finalzied!!

Keep up the good work guys and keep feeding us your opinions they are important.

MuppetBingo · #68 08-01-2007, 04:28 PM

Hmm, the action-attributes need to be of the same type, ie. <action> instead of <bet> for it to be a proper sequence.

Here's version 1.1

<font class="small">Code:</font><hr /><pre>
<?xml version="1.0"?>
<pokerhand id="11082740019" timestamp="2007-07-31 11:21:43">
<context>
<location online="true">
<room name="Absolute Poker" />
<table id="562102981" name="Denmark Dr." seats="10"/>
</location>

<game type="texasholdem" format="tournament" bettingtype="nolimit">

<tournament buyin="10" vig="1" id="56210298" currency="USD"/>

<cashgame maxbuyin="400" bigblind="2" currency=""/>
</game>
<players>
<player id="MuppetBingo" stack="1500" seat="1" sittingout="false"/>
<player id="KermitIsGreen" stack="1500" seat="4" sittingout="false"/>
<player id="Animal" stack="1500" seat="5" sittingout="false"/>
</players>
</context>
<rounds>

<antes>
<ante playerId="MuppetBingo" amount="2"/>
<ante playerId="KermitIsGreen" amount="2"/>
<ante playerId="Animal" amount="2"/>
</antes>


<round id="preflop">

<deal>

<cards playerId="MuppetBingo" open="false" value="Ac Ad"/>
</deal>

<actions>




<action type="bet" playerId="MuppetBingo" forced="true" name="smallblind" amount="10"/>
<action type="bet" playerId="KermitIsGreen" forced="true" name="bigblind" amount="20"/>
<action type="bet" playerId="Animal" forced="false" name="straddle" amount="40"/>
<action type="bet" playerId="MuppetBingo" amount="10"/>
<action type="bet" playerId="KermitIsGreen" amount="30"/>
<action type="call" playerId="Animal" amount="30"/>
<action type="call" playerId="MuppetBIngo" amount="20"/>
</actions>
</round>
<round id="flop">
<deal>

<cards open="true" value="7c 2s Qh"/>
</deal>
<actions>
<action type="check" playerId="MuppetBingo" />
<action type="bet" playerId="KermitIsGreen" amount="50"/>
<action type="fold" playerId="Animal"/>
<action type="call" playerId="MuppetBIngo" amount="50"/>
</actions>
</round>
<round id="turn">
<deal>
<cards open="true" value="9h"/>
</deal>
<actions>
<action type="check" playerId="MuppetBingo"/>
<action type="check" playerId="KermitIsGreen"/>
</actions>
</round>
<round id="river">
<deal>
<cards open="true" value="Kc"/>
</deal>
<actions>
<action type="check" playerId="MuppetBingo" />
<action type="check" playerId="KermitIsGreen" />
</actions>
</round>
</rounds>
<result>
<hands>

<hand playerId="MuppetBingo" mucked="false" cards="Ac Ad"/>
<hand playerId="KermitIsGreen" mucked="false" cards="As Ks"/>
<hand playerId="Animal" mucked="true"/>
</hands>
<pots value="278.5" rake="1.5">
<pot number="1" value="278.5">
<winners>

<winner playerId="MuppetBingo" amount="278.5" winningHand="Ac Ad Qh Kc 9h"/>
</winners>
</pot>
</pots>
</result>
</pokerhand>
</pre><hr />

* Changed the structure of <result> a bit, so that <pots> now holds the total value of all pots, with rake removed.

Shoe Lace · #69 08-01-2007, 05:04 PM

I do not understand why you have an ante section. Antes are forced action to whoever is dealt a hand at the table.

If 6 people are sitting at the table and the ante is 2 then each person is always going to put in 2. There is no reason to have this info posted for each player.

This info is automatically taken into account when getting their initial stack size.

ie. They would start with a 998 stack instead of 1000 (would require no code because their stack size is effected by the ante when they are dealt a hand).

The ante attribute is only needed to calculate the pot size and to let us know the table does have an ante present.

TheIrishThug · #70 08-01-2007, 05:16 PM

You are right that you don't need to list all the players paying their ante. But it should be included to calculate each player's net for the hand. So you would have an explanation for why after three hands of folding pre-flop, my stack has gone from 1000 to 994.