Two Plus Two Newer Archives

Two Plus Two Newer Archives (http://archives1.twoplustwo.com/index.php)
-   Software (http://archives1.twoplustwo.com/forumdisplay.php?f=47)
-   -   Party Poker Hand Reviewer - Alpha Test (http://archives1.twoplustwo.com/showthread.php?t=63798)

Saint_D 03-17-2006 04:23 PM

Party Poker Hand Reviewer - Alpha Test
 
Over in small Micro-Limit land we have been doing a lot of session review swaps. It's sort of a pain in the butt.

1. you have to do a lot of search and replace if you want to "Wash" your history files.
2. You have to open at least two programs to see the hands play out and make notes.
3. formatting the notes back to your partner is time consuming.

I have whipped out a program that is meant to make this less painful. Currently it only works on Party session files.

Requires the DotNet 2.0 framework

I have applied to SorceForge for a place to put this project. In the mean time you can get a copy here.

HandReview.zip

PM me if you want the source in the mean time.

See readme for more information.

-D

gulon 03-17-2006 05:24 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
Saint,
I'm a software developer as well. Please post up when you've got it on SourceForge, i'd be happy to pitch in and expand this.

Saint_D 03-17-2006 05:39 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
Screenie:
http://www.darksun.lunarpages.com/poker/HandReview.jpg

bravos1 03-17-2006 06:18 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
Saint,

Looks like a great start. Already PM'd you regarding the source. Here is what I have found in my 15 minute browse so far.

Bugs:
1. When the hand ends early (ie no turn or river), the tool lets you continue through a blank turn and river and then gives you the results. Doesn't really break anything, but should stop at the street the hand stops at.

2. Looking through your example HH, the parser seems to be a bit off. There is never a player on the button. The player who is really OTB is identified as CO and the player to his/her left as SB.

Feature requests (already.. I know [img]/images/graemlins/grin.gif[/img])
1. At the start of the flop, turn, and river, it would be nice to see the pot size (SB for flop, BB for turn and river) to help calculate odds and that street's decision.
2. It may be helpful to also track where in the session you are. If I upload 100 hands, you could have somewhere Hand xx/100 or hand xx of 100, etc. This may be just as helpful as having the real hand number.
3. If I decide to "wash" a HH, let the user select the player to be Hero (I'm sure this is already on your list).


More to come.

BTW, what are your plans for other site support besides party? I understand that keeping up with changes to HHs is difficult at best. What about supporting a "common" format to upload? This HH Converter is pretty decent and seems to be more and more commonly used. I know you have no control of how he converts hands, but it may help with supporting multiple sites if you were to try and use his 2p2 or FTP outputs? That site also converts multiple ands so it may be a good fit.

Saint_D 03-17-2006 06:52 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
[ QUOTE ]

Bugs:
1. When the hand ends early (ie no turn or river), the tool lets you continue through a blank turn and river and then gives you the results. Doesn't really break anything, but should stop at the street the hand stops at.


[/ QUOTE ]

This I know about. I am not sure how I want to handle it, and at what layer.

[ QUOTE ]

2. Looking through your example HH, the parser seems to be a bit off. There is never a player on the button. The player who is really OTB is identified as CO and the player to his/her left as SB.


[/ QUOTE ]

[img]/images/graemlins/blush.gif[/img] My technique for labeling players is faulty. I don't see anything obvious in the code. It does get the blinds right at least. I need to step through the code or come up with a new approach. The approach I have is broken for less than 5 players anyway.

[ QUOTE ]

Feature requests (already.. I know [img]/images/graemlins/grin.gif[/img])
1. At the start of the flop, turn, and river, it would be nice to see the pot size (SB for flop, BB for turn and river) to help calculate odds and that street's decision.


[/ QUOTE ]

Already on the list. Once again, not sure which layer it belongs in.

[ QUOTE ]

2. It may be helpful to also track where in the session you are. If I upload 100 hands, you could have somewhere Hand xx/100 or hand xx of 100, etc. This may be just as helpful as having the real hand number.


[/ QUOTE ]

You get a visual reference on the left hand side, but you have a point that it is pretty rough. I will keep this in mind. Not sure where the best place to display it is.

[ QUOTE ]

3. If I decide to "wash" a HH, let the user select the player to be Hero (I'm sure this is already on your list).


[/ QUOTE ]

Hmm, Actually I was pretty happy with the auto-detection of the hero. Why is picking from a list better?

[ QUOTE ]

BTW, what are your plans for other site support besides party? I understand that keeping up with changes to HHs is difficult at best. What about supporting a "common" format to upload? This HH Converter is pretty decent and seems to be more and more commonly used. I know you have no control of how he converts hands, but it may help with supporting multiple sites if you were to try and use his 2p2 or FTP outputs? That site also converts multiple ands so it may be a good fit.

[/ QUOTE ]

I might look at it. For some work-related reasons, all the code in this project my be original or under a set of very few, very liberal licenses. Also, I don't want the application to use the internet at all. I want people to be able to set deny it access to the internet and still have it work. (lots of people rely on that for stuff that touches thier poker stuff, and I don't blame them.)

The parser module is seperate from the display level. I need to go back and define a parser interface so I can add more parsers. But I know exactly how that will look and work. The parser architecture I have is a good blue print for cranking out more.

I did consider for a while creating parsers that would create a "neutral" XML format for hands. But it's more work than I wanted to deal with at first. With the parser I have, I could write a module on top that would XML the hands neatly. Sort of like I RTF them now.

I am hoping to solve some of the history file format churn problem by making this a sourceforge project. Then whomever is feeling the pain can provide the fix or at least log a bug and provide sample hands.

Another thing on the list is an RTF to 2p2 format converter. [img]/images/graemlins/smile.gif[/img]

-D

Saint_D 03-17-2006 08:05 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
Zip file updated with "button" fix. The button seems to be showing up correctly now.

Please let me know if the hands sequence is right. This is my chart for 2 handed to 10 handed. Is it right?

{"button", "bb"}, // is this always true?
{"button", "sb", "bb"},
{"button", "sb", "bb", "UTG"},
{"button", "sb", "bb", "UTG", "cutoff"},
{"button", "sb", "bb", "UTG", "hijack", "cutoff"},
{"button", "sb", "bb", "UTG", "UTG"+"1", "hijack", "cutoff"},
{"button", "sb", "bb", "UTG", "UTG"+"1", "mp1", "hijack", "cutoff"},
{"button", "sb", "bb", "UTG", "UTG"+"1", "mp1", "mp2", "hijack", "cutoff"},
{"button", "sb", "bb", "UTG", "UTG"+"1", "mp1", "mp2", "mp3", "hijack", "cutoff"}

ThunderEagle 03-18-2006 09:23 AM

Re: Party Poker Hand Reviewer - Alpha Test
 
OK, first thing right off the bat, need to redo that form so that the controls actually resize. One of my biggest pet peeves is non-resizable forms. [img]/images/graemlins/smile.gif[/img]

Everytime I find a program at work that doesn't resize I have to resist the urge to track down the engineer and slap them silly, and yes, I'm an engineer myself.

Once you get your sourceforge project up and running I can take a look at some of the form stuff if you like, I'm also curious if you are using RegEx for the file parsing?

Saint_D 03-18-2006 04:18 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
[ QUOTE ]
OK, first thing right off the bat, need to redo that form so that the controls actually resize. One of my biggest pet peeves is non-resizable forms. [img]/images/graemlins/smile.gif[/img]

Everytime I find a program at work that doesn't resize I have to resist the urge to track down the engineer and slap them silly, and yes, I'm an engineer myself.

Once you get your sourceforge project up and running I can take a look at some of the form stuff if you like, I'm also curious if you are using RegEx for the file parsing?

[/ QUOTE ]

Resizable is on my list of things to do. Really the IDE should handle that by Default IMHO.

I use Regex liberally in the parser. I was a Perl programmer for years, so it's like a second language to me.

ThunderEagle 03-18-2006 04:55 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
[ QUOTE ]

Resizable is on my list of things to do. Really the IDE should handle that by Default IMHO.



[/ QUOTE ]

Actually, it basically does now in .Net, there are properties on the controls you need to set. There is some leg work involved, but not writing code to do it like in the past.

Saint_D 03-21-2006 05:46 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
Project is now on SourceForge: http://www.sourceforge.net/projects/handreview

email me from the link provided there if you wish to contribute.

Please feel free to upload feature requests and bugs there as well.

jively 03-21-2006 05:54 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
button, sb, bb, UTG, UTG+1, UTG+2, MP1, MP2, MP3, CO is more standard, I think.

The button is on the SB when heads up.

-Tom

Mogobu The Fool 03-21-2006 06:22 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
[ QUOTE ]
button, sb, bb, UTG, UTG+1, UTG+2, MP1, MP2, MP3, CO is more standard, I think.

The button is on the SB when heads up.

-Tom

[/ QUOTE ]

HU blinds depend on the house. At Party, they use the Button-Small-Big tradition, which puts the Big on the button.

Also, the "names" like UTG, CO, MP, are not strong conventions. They vary from author to author, and site to site. I stick with OTB (off the button) notation. I.e., for 8 players dealt in,
S, B, 5, 4, 3, 2, 1, D.

Saint_D 03-22-2006 02:38 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
New version with fix for new party histories.

http://prdownloads.sourceforge.net/h...1.zip?download

Still lots of bugs in the seating detection. I am working on it.

ThunderEagle 03-22-2006 03:02 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
[ QUOTE ]
Also, the "names" like UTG, CO, MP, are not strong conventions. They vary from author to author, and site to site. I stick with OTB (off the button) notation. I.e., for 8 players dealt in,
S, B, 5, 4, 3, 2, 1, D.

[/ QUOTE ]

A point of contention. The inspiration behind this I believe is the Session reviews that we do over on the Micros forum and we use BisonBison's hand coverter (or something based on it) that uses SB, BB, UTG, UTG+1, UTG+2, UTG+3, MP1, MP2, MP3, CO, Button for positions. I think the converted output should match that convention and formatting.

Saint_D 03-23-2006 12:16 AM

Re: Party Poker Hand Reviewer - Alpha Test
 
[ QUOTE ]
[ QUOTE ]
Also, the "names" like UTG, CO, MP, are not strong conventions. They vary from author to author, and site to site. I stick with OTB (off the button) notation. I.e., for 8 players dealt in,
S, B, 5, 4, 3, 2, 1, D.

[/ QUOTE ]

A point of contention. The inspiration behind this I believe is the Session reviews that we do over on the Micros forum and we use BisonBison's hand coverter (or something based on it) that uses SB, BB, UTG, UTG+1, UTG+2, UTG+3, MP1, MP2, MP3, CO, Button for positions. I think the converted output should match that convention and formatting.

[/ QUOTE ]

Good point. I will use the conventions from that converter. This is supposed to be sort of a windows application clone of that anyway.

However, As listed you have 11 positions. Does UTG+3 ever come up from the converter?

ThunderEagle 03-23-2006 02:42 AM

Re: Party Poker Hand Reviewer - Alpha Test
 
Sorry, got carried away with the UTG's, it should stop with UTG+2

Saint_D 03-23-2006 07:02 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
New version released:
http://prdownloads.sourceforge.net/h...0.zip?download

Many fixes, including:
<ul type="square">[*] Exception reports when trying to open hands (index &lt; 0 bug)[*] Save to RTF now saves all checked hands, not just modified ones.[*] seat positions fixed.[*] Progress bar for save to RTF.[*] new menu items for select/unselect on menu bar and right click menus.[*] CTRL-A support.[/list]
Here is a trick someone asked for so they can export an entire history file to RTF for editing in word.
<ul type="square">
[1] open history file
[2] pick "select all hands" from the right click menu
[3] pick file-&gt;save checked hands as rtf...[/list]

Saint_D 03-23-2006 08:34 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
To do in next update:[*] progress bar for "anonamize"[*] Remember the last folder you saved or loaded from and look there by default.[*] fix control resizing.

Anyone else have any asks?

jjpike 03-24-2006 11:37 AM

Re: Party Poker Hand Reviewer - Alpha Test
 
I'd like to see some improvement in the UI. Move the buttons to a toolbar and some panels/resizing ability of the hand listbox.

Also, I've pretty much got PokerStars hand history files parsed using regex to add to an xml file. Do you plan on making the different hand converters providers or some other type of pluggable feature?

jjpike

MarkD 03-24-2006 12:37 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
I don't know if it does this or not but here is a suggestion that should be easy to implement.

Let's say you have x hands in a session from y tables. It would be nice for the replayer to have the ability to break the session into individual sessions for each of the y tables so you can play through one table at a time and get a better feel for the dynamic of that table and how it was playing.

Pokertracker has this ability for replaying sessions and I have really been enjoying that.

Saint_D 03-24-2006 04:24 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
[ QUOTE ]
I'd like to see some improvement in the UI. Move the buttons to a toolbar and some panels/resizing ability of the hand listbox.


[/ QUOTE ]

I am not sure exactly what you are proposing here. Maybe if you drew me a picture? Or better yet, download the source from the forge and send me your proposed fixes. [img]/images/graemlins/cool.gif[/img]

[ QUOTE ]


Also, I've pretty much got PokerStars hand history files parsed using regex to add to an xml file. Do you plan on making the different hand converters providers or some other type of pluggable feature?

jjpike

[/ QUOTE ]

Short answer: Yes, more parsers are on the list.


Long Answer: Some moderately time consuming work needs to be done first. The current parsers needs to be abstracted to a base class and the UI needs a way to pick which loaded parses it's going to use.

The current parser uses regex. Translating hands into an XML format is also an idea that I had, but didn't follow through with. It's probably a better overall approach and I am considering a retro-fit before it's too late.

jjpike 03-24-2006 08:50 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
I'll download the source and try to modify it this weekend.

jjpike 03-26-2006 03:39 AM

Re: Party Poker Hand Reviewer - Alpha Test
 
I downloaded, modified and emailed you the modified source.

AngelicPenguin 03-27-2006 12:30 AM

Re: Party Poker Hand Reviewer - Alpha Test
 
I don't think the Hand Reviewer is showing mucked hands.

Neat program though!

-Matthew

Saint_D 03-27-2006 06:34 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
[ QUOTE ]
I don't think the Hand Reviewer is showing mucked hands.

Neat program though!

-Matthew

[/ QUOTE ]

Can you PM me a hand history where you think it didn't show you something it should have?

kleos 03-27-2006 08:58 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
just looking at the screeny, you should add the stack size.

Saint_D 03-27-2006 09:48 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
[ QUOTE ]

You should add the stack size.


[/ QUOTE ]

Good point. I am a limit player so I don't generally think about the stack sizes. In fact, I filtered them out. I will put it on the list to fix.

ThunderEagle 03-28-2006 02:53 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
[ QUOTE ]
[ QUOTE ]

You should add the stack size.


[/ QUOTE ]

Good point. I am a limit player so I don't generally think about the stack sizes. In fact, I filtered them out. I will put it on the list to fix.

[/ QUOTE ]

It should be an option, just like in the HandConverters just for this reason, we don't care with Limit, and it means a lot in NL.

Hoss Ballgag 04-03-2006 03:31 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
This program is awesome! However, Pot Size is critical to proper review. Are you adding this to the program and if so, when can we expect it? Thanks man!

Saint_D 04-04-2006 02:10 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
[ QUOTE ]
This program is awesome! However, Pot Size is critical to proper review. Are you adding this to the program and if so, when can we expect it? Thanks man!

[/ QUOTE ]

We are having some technical problems with Sourceforge this week. Pot Size is high on the list. We are working on revamping the parsing engine. That will take about a week. Once that part is done, getting the pot size will be trivial.

JJPike and ThunderEagle are working on the UI and have made some nice improvements. Keep the feedback coming. It really motivates us to keep working on the program.

Please feel free to log bus and feature requests in this thread, by PM, or at http://www.sourceforge.net/projects/handreview

-D

AngelicPenguin 04-16-2006 10:33 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
Sorry, didn't check the response. I used it on the last review and I just didn't hit the arrow one last time for the results. So no problems! [img]/images/graemlins/smile.gif[/img]

-Matthew

AngelicPenguin 04-16-2006 10:37 PM

Re: Party Poker Hand Reviewer - Alpha Test
 
Feature requests:
How about hotkeys for navigating. That way you can really fly through the hands.

Maybe a 4 color deck option?

Looking good, though.

-Matthew


All times are GMT -4. The time now is 05:46 AM.

Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2026, vBulletin Solutions Inc.